fix(scan): honor case sensitivity when binding filters#2500
Open
officialasishkumar wants to merge 1 commit into
Open
fix(scan): honor case sensitivity when binding filters#2500officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Use the TableScanBuilder case_sensitive setting when binding scan predicates so case-insensitive scans resolve filter references consistently. Add a regression test covering an uppercase filter reference against a lowercase schema field.
viirya
approved these changes
May 31, 2026
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Clean, correctly-scoped fix. snapshot_bound_predicate was the only place still hardcoding bind(schema, true) while the actual scan predicate threaded self.case_sensitive through, so a case-insensitive scan with an uppercase reference would fail to bind. Good regression test.
One out-of-scope note: the projected-column loop above (field_id_by_name) is still case-sensitive only, so with_case_sensitive(false) covers filters but not column projection. Not this PR's concern, just flagging for a possible follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
TableScanBuildercase sensitivity.Are these changes tested?
CARGO_TARGET_DIR=/tmp/iceberg-rust-target cargo test --locked -p iceberg test_filter_with_case_insensitive_reference -- --nocapturecargo fmt --all -- --checkgit diff --check